chore(MR-664): Track outgoing responses in streams #4561
+238
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds some tracking of guaranteed responses to streams. In an upcoming PR, this information will be added to the `canister_status` endpoint of the management canister and in an even later upcoming PR the canister migration logic will depend on that information.
|
Thanks! Did a quick skim. Mostly looks good to me. I think it would be good to add test coverage for the counting and also the new function deciding whether things are ready to migrate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some tracking of guaranteed responses to streams. In an upcoming PR, this information will be added to the
canister_statusendpoint of the management canister and in an even later upcoming PR the canister migration logic will depend on that information.