feat(sns): Extend cast_vote_and_cascade_follow to take topic-based following into account
#4583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterga
force-pushed
the
arshavir/NNS1-3711-2
branch
from
be9a1b5 to
31e7d12
Compare
aterga
commented
Mar 31, 2025
| @@ -318,6 +325,90 @@ impl Neuron { | |||
| Vote::Unspecified | |||
| } | |||
|
|
|||
| /// Analogous to `would_follow_ballots`, but for topic-based following. | |||
| pub(crate) fn would_topic_follow_ballots( | |||
There was a problem hiding this comment.
Suggested change
| pub(crate) fn would_topic_follow_ballots( | |
| pub(crate) fn would_follow_ballots_based_on_topic( |
There was a problem hiding this comment.
Make this top-level, handle the fallback inside
aterga
commented
Mar 31, 2025
| continue; | ||
| }; | ||
|
|
||
| // Supporting topic-based following with legacy (function-based) as fallback. |
aterga
commented
Mar 31, 2025
| ballots, | ||
| proposal_criticality, | ||
| ); | ||
| } |
There was a problem hiding this comment.
... till here, can all go into a dedicated method on Neuron
aterga
commented
Mar 31, 2025
| @@ -3635,9 +3794,16 @@ impl Governance { | |||
| // not (directly or indirectly) voted yet). That is, once a neuron is swayed, | |||
| // its vote is "locked in". IOW, swaying is "monotonic". | |||
| while !induction_votes.is_empty() { | |||
| #[derive(Eq, Ord, PartialEq, PartialOrd)] | |||
| enum FollowingType { | |||
There was a problem hiding this comment.
This info is most likely not necessary
Try to rewrite without keeping track of the edge type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements topic-based following, which legacy (function-based) following is kept as a fallback.
< Previous PR |