Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export types used by the Datasource class #353

Merged
merged 1 commit into from
Jul 6, 2024
Merged

fix: export types used by the Datasource class #353

merged 1 commit into from
Jul 6, 2024

Conversation

arturovt
Copy link
Contributor

@arturovt arturovt commented Jul 5, 2024

We need to export these interfaces because they are used by the compiler, so they should be exposed publicly from the module entry point.

image

We need to export these interfaces because they are used by the compiler,
but they should not be exposed publicly from the module entry point.
@dhilt dhilt merged commit 337964e into dhilt:master Jul 6, 2024
2 checks passed
@dhilt
Copy link
Owner

dhilt commented Jul 6, 2024

@arturovt Would be nice to have a repro and try to solve the problem without exporting the util types. Meanwhile, I have published ngx-ui-scroll v3.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants