Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use result.*Count to enable newer mongodb driver versions. #119

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

dlongley
Copy link
Member

@dlongley dlongley commented Mar 3, 2025

No description provided.

@dlongley dlongley requested a review from davidlehn March 3, 2025 23:35
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (621b43f) to head (33837e9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   92.55%   92.55%           
=======================================
  Files          12       12           
  Lines        3534     3534           
=======================================
  Hits         3271     3271           
  Misses        263      263           
Files with missing lines Coverage Δ
lib/batchVersions.js 87.82% <100.00%> (ø)
lib/documents.js 92.36% <100.00%> (ø)
lib/entities.js 96.03% <100.00%> (ø)
lib/tokens/batches.js 93.19% <100.00%> (ø)
lib/tokens/pairwise.js 83.18% <100.00%> (ø)
lib/tokens/resolve.js 94.98% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 621b43f...33837e9. Read the comment docs.

@davidlehn davidlehn self-requested a review March 4, 2025 02:10
Copy link
Member

@davidlehn davidlehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the upsertedCount check comment, then approved.

@dlongley dlongley requested a review from davidlehn March 4, 2025 15:49
@dlongley
Copy link
Member Author

dlongley commented Mar 4, 2025

Addressed the above upsertedCount.

@dlongley dlongley merged commit 8ebdfda into main Mar 4, 2025
4 checks passed
@dlongley dlongley deleted the use-modifiedCount branch March 4, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants