Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unmaintained libraries #3725

Closed
wants to merge 3 commits into from
Closed

Remove unmaintained libraries #3725

wants to merge 3 commits into from

Conversation

MattIPv4
Copy link
Contributor

@MattIPv4 MattIPv4 commented Aug 28, 2021

This PR removes discord.py, disco and Sword from the community resources libraries list as the libraries are unmaintained (GitHub repos have been archived) and they do not provide an interface for Slash Commands, which appears to be the recommended approach to implement a bot on Discord now.

Library is unmaintained and does not support Slash Commands which appear to be the recommended approach to implement a bot.
Library is unmaintained and does not support Slash Commands which appear to be the recommended approach to implement a bot.
@Mehgugs
Copy link
Contributor

Mehgugs commented Aug 28, 2021

You should also remove Sword, it's archived I believe.

Library is unmaintained and does not support Slash Commands which appear to be the recommended approach to implement a bot.
@GanerCodes
Copy link

brO IT WAS JUST ANNOUNCED CALM DOWN

@Mehgugs
Copy link
Contributor

Mehgugs commented Aug 28, 2021

In my discussion I mentioned that it would be nice for discord to look at this "curated" list and their commitments to it, so im going to plug it here because it's partially relevant. Again any guidelines from discord on when something should be removed would be nice.

@ghost
Copy link

ghost commented Aug 28, 2021

this PR was unbelievably fast to appear

@msciotti msciotti closed this Aug 28, 2021
@MattIPv4
Copy link
Contributor Author

@msciotti would appreciate a reason here -- seems odd that y'all on your own site are linking to libraries that implement bots using messages rather than Slash Commands given you're encouraging devs to switch to those, and these libraries are all completely archived and unmaintained?

@Mehgugs
Copy link
Contributor

Mehgugs commented Aug 28, 2021

There's multiple libraries on that list less compliant than d.py

@advaith1
Copy link
Contributor

this PR removes all of the archived repositories, none of the other repos are archived

@MattIPv4
Copy link
Contributor Author

@Mehgugs For sure, I think your discussion definitely captures the wider issues with the list as a whole, its in an odd state of affairs it seems

@ghost
Copy link

ghost commented Aug 28, 2021

@Mehgugs For sure, I think your discussion definitely captures the wider issues with the list as a whole, its in an odd state of affairs it seems

what do you mean by "odd state of affairs?" it's not like slash commands came out two years ago and are already widely implemented

@Column01
Copy link

It clearly states it's curated around

libraries that conform to our API's standards around authentication and rate-limiting

It doesn't even mention if the full API is implemented as being a condition to be in the list. Not sure why you'd assume since a library is archived that it would no longer meet their standards of rate-limiting and authentication. Whether it implements parts of the API that a user needs is up to them to figure out, not saying whether that is good or bad, but these libraries technically meet the requirements to still be on that list.

Word for word from the page:

The Discord team curates the following list of officially vetted libraries that conform to our APIs standards around authentication and rate limiting

@Mehgugs
Copy link
Contributor

Mehgugs commented Aug 28, 2021

No one knows what the standards are definitively. As far as I am aware it's a less strict version of the discord api guild's library developer requirements that is informally checked with common sense.

@siddhantshr
Copy link

Calm down bro, what the fuck do you want?

@discord discord locked as too heated and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants