Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timestamp defaults #1557

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Timestamp defaults #1557

merged 10 commits into from
Jun 6, 2024

Conversation

msosnicki
Copy link
Contributor

@msosnicki msosnicki commented Jun 3, 2024 •
edited by kubukoz
Loading

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

fixes #1535

@msosnicki msosnicki marked this pull request as ready for review June 3, 2024 14:02
kubukoz
kubukoz reviewed Jun 3, 2024
View reviewed changes
@kubukoz kubukoz merged commit 19acfb2 into disneystreaming:series/0.18 Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenguyenthanh lenguyenthanh lenguyenthanh left review comments

@kubukoz kubukoz kubukoz approved these changes

@Baccata Baccata Baccata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@default support for timestamps
4 participants
@msosnicki @lenguyenthanh @kubukoz @Baccata