Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement getMessage in Smithy4sThrowable #1572

Merged
merged 4 commits into from
Aug 5, 2024
Merged

implement getMessage in Smithy4sThrowable #1572

merged 4 commits into from
Aug 5, 2024

Conversation

lewisjkl
Copy link
Contributor

@lewisjkl lewisjkl commented Aug 1, 2024

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

Closes #1497

@Baccata Baccata merged commit 7afbb5c into series/0.18 Aug 5, 2024
20 checks passed
@Baccata Baccata deleted the get-message-smithy4sthrowable branch August 5, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baccata Baccata Baccata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a default implementation for getMessage in Smithy4sThrowable 
2 participants
@lewisjkl @Baccata