-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #1539 kebab caseificiation #1603
Closes #1539 kebab caseificiation #1603
Conversation
…camel case to kebab case. Fixes 1539
|
It doesn't look like github linked this PR back to #1539 . What's the right way to make that happen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the formatter is complaining, can you run sbt scalafmt
and commit the results? Thanks!
|
||
import weaver._ | ||
|
||
object commonsSpec extends FunSuite { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: in tests, we usually name objects starting with an uppercase letter... although the object being tested is commons
, I would probably rename this to match other suites
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in a PR about camel-case no less.
No luck. I wonder if I had to get it right the first time. |
Thank you ! |
Glad to. Next let me see if I can pick up something with a little more smithy4s in it. |
PR Checklist (not all items are relevant to all PRs)