Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #1539 kebab caseificiation #1603

Merged

Conversation

dwalend
Copy link
Contributor

@dwalend dwalend commented Oct 1, 2024

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dwalend
Copy link
Contributor Author

dwalend commented Oct 1, 2024

It doesn't look like github linked this PR back to #1539 . What's the right way to make that happen?

@kubukoz
Copy link
Member

kubukoz commented Oct 1, 2024

It doesn't look like github linked this PR back to #1539 . What's the right way to make that happen?

I think you need a hash in the PR title. Ideally, you can say "Closes #1539" and it'll link them so that when the PR gets merged, the issue gets closed.

Copy link
Member

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the formatter is complaining, can you run sbt scalafmt and commit the results? Thanks!


import weaver._

object commonsSpec extends FunSuite {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: in tests, we usually name objects starting with an uppercase letter... although the object being tested is commons, I would probably rename this to match other suites

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in a PR about camel-case no less.

@dwalend dwalend changed the title Fixes 1539 kebab caseificiation Fixes #1539 kebab caseificiation Oct 1, 2024
@dwalend dwalend changed the title Fixes #1539 kebab caseificiation Closes #1539 kebab caseificiation Oct 1, 2024
@dwalend
Copy link
Contributor Author

dwalend commented Oct 1, 2024

It doesn't look like github linked this PR back to #1539 . What's the right way to make that happen?

I think you need a hash in the PR title. Ideally, you can say "Closes #1539" and it'll link them so that when the PR gets merged, the issue gets closed.

No luck. I wonder if I had to get it right the first time.

@dwalend dwalend mentioned this pull request Oct 1, 2024
@Baccata Baccata merged commit 85cf6a0 into disneystreaming:series/0.18 Oct 1, 2024
11 checks passed
@Baccata
Copy link
Contributor

Baccata commented Oct 1, 2024

Thank you !

@dwalend dwalend deleted the fix-kebab-caseificiation-1539 branch October 1, 2024 11:38
@dwalend
Copy link
Contributor Author

dwalend commented Oct 1, 2024

Thank you !

Glad to. Next let me see if I can pick up something with a little more smithy4s in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants