Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for flexible defaults encoding #1652

Merged
merged 44 commits into from
Mar 12, 2025
Merged

feat: Add support for flexible defaults encoding #1652

merged 44 commits into from
Mar 12, 2025

Conversation

ghostbuster91
Copy link
Contributor

@ghostbuster91 ghostbuster91 commented Feb 20, 2025 •
edited
Loading

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified) N/A
  • Added build-plugins integration tests (when reflection loading is required at codegen-time) N/A
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated) N/A
  • Updated dynamic module to match generated-code behaviour N/A
  • Added documentation
  • Updated changelog

Refers to #1398

@ghostbuster91
Copy link
Contributor Author

I am not happy about the implementation of SkipIfEmptyCollection so I am fine with dropping it at this stage to minimize the amount of changes, but wanted to showcase it in case you think that it is worth to have something like that.

@Baccata
Copy link
Contributor

Baccata commented Feb 21, 2025

A good start 👍

@ghostbuster91
Copy link
Contributor Author

@kubukoz wanna have a look?

@ghostbuster91 ghostbuster91 force-pushed the feat/flexible-defaults branch from 61e124e to 288af6a Compare March 7, 2025 16:15
kubukoz
kubukoz approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baccata please have a final look too

@Baccata
Copy link
Contributor

Baccata commented Mar 12, 2025

Good work. Just a couple nitpicks (and also this : #1652 (comment))

@kubukoz kubukoz merged commit 1c1e16d into disneystreaming:series/0.18 Mar 12, 2025
11 checks passed
@ghostbuster91 ghostbuster91 deleted the feat/flexible-defaults branch March 12, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kubukoz kubukoz kubukoz approved these changes

@Baccata Baccata Baccata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghostbuster91 @Baccata @kubukoz