Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force rendering package object when a validated newtype is present #1656

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Feb 24, 2025

Closes #1655

PR Checklist (not all items are relevant to all PRs)

  • Added unit-tests (for runtime code)
  • Added bootstrapped code + smoke tests (when the rendering logic is modified)
  • Added build-plugins integration tests (when reflection loading is required at codegen-time)
  • Added alloy compliance tests (when simpleRestJson protocol behaviour is expanded/updated)
  • Updated dynamic module to match generated-code behaviour
  • Added documentation
  • Updated changelog

} else blk
val packageContents = lines(serviceAliases, newline, typeAliases, newline)

packageContents.some
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: that should prevent these things happening in the future 🤞

@kubukoz kubukoz marked this pull request as ready for review February 24, 2025 14:45
@kubukoz kubukoz merged commit 00bc26f into series/0.18 Feb 27, 2025
11 checks passed
@Baccata Baccata deleted the validated-newtypes-force-package branch February 27, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A lone validated newtype breaks compilation
2 participants