Make ShapeId a datatype #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use it as a hint everywhere. The rationale is as follows : 1. would be useful for error messages 2. will be required for implementing some protocols 3. `ShapeId` can be used as a map key for dynamic purposes
Baccata
commented
Jan 4, 2022
|
|
||
| case class ServerErrorCase(serverError: ServerError) extends GetObjectError | ||
|
|
||
| object ServerErrorCase { | ||
| val hints : smithy4s.Hints = smithy4s.Hints() | ||
| val hints : smithy4s.Hints = smithy4s.Hints( | ||
| id, |
There was a problem hiding this comment.
Oops, this one should not been rendered.
lewisjkl
previously approved these changes
Jan 4, 2022
kubukoz
previously approved these changes
Jan 4, 2022
kubukoz
reviewed
Jan 5, 2022
| @@ -211,9 +212,9 @@ object MetadataSpec extends FunSuite { | |||
|
|
|||
| test("map of list of strings query param") { | |||
There was a problem hiding this comment.
The name seems not to be accurate anymore, same in the other test
kubukoz
approved these changes
Jan 5, 2022
Closed
Baccata
added a commit
that referenced
this pull request
May 10, 2022
* Makes ShapeID a datatype, that can be used as a hint, and as a key to maps. * Change rendering of newtype to facilitate the use of ids as hints * Bump smithy to 1.16.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use it as a hint everywhere. The rationale is as follows :
ShapeIdcan be used as a map key for dynamic purposes