add header validator #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewisjkl
force-pushed
the
add-header-validator
branch
from
d21a962 to
7c6f900
Compare
kubukoz
reviewed
Jan 6, 2022
| return model.getShapesWithTrait(HttpHeaderTrait.class).stream().flatMap(headerShape -> { | ||
| String value = headerShape.getTrait(HttpHeaderTrait.class).get().getValue(); | ||
| if (disallowedHeaderNames.contains(value)) { | ||
| return Stream.of(error(headerShape, String.format("Header named `%s` should not be present since it is automatically filled", value))); |
There was a problem hiding this comment.
Maybe we should mention the @mediaType trait here
There was a problem hiding this comment.
Not sure, tbh. Like, the simpleRestJson protocol doesn't take it into consideration
There was a problem hiding this comment.
Also, error is too hard a severity. It might be that someone provides an implementation that allows for it, so
the error severity should only be used if we check that the header is in the closure of a simpleRestJson service.
If we don't perform that check, it should be a warning, not an error
Baccata
reviewed
Jan 6, 2022
| public List<ValidationEvent> validate(Model model) { | ||
| return model.getShapesWithTrait(HttpHeaderTrait.class).stream().flatMap(headerShape -> { | ||
| String value = headerShape.getTrait(HttpHeaderTrait.class).get().getValue(); | ||
| if (disallowedHeaderNames.contains(value)) { |
There was a problem hiding this comment.
Headers are case insensitive, so this doesn't quite cut it
Baccata
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validator to make sure headers cannot be set if they are automatically set down the line.
Closes #28.