remove core dependency auto-add from sbt plugin #38
Conversation
| @@ -30,9 +30,11 @@ import smithy4s.codegen.Smithy4sCodegenPlugin | |||
| val myModule = project | |||
| .in(file("modules/my-module")) | |||
| .enablePlugins(Smithy4sCodegenPlugin) | |||
| // version for smithy4s-core is sourced from Smithy4sCodegenPlugin | |||
| .settings(libraryDependencies += "com.disneystreaming.smithy4s" %%% "smithy4s-core" % smithy4sVersion.value) | |||
There was a problem hiding this comment.
%%% won't work on builds without scalajs. In general, I think this approach is non-ideal (asking people to add the dependency themselves) but I don't have a better idea for now :/ hoping @Baccata has something better
There was a problem hiding this comment.
ah, I now see the comment in #34 saying it's already been discussed
There was a problem hiding this comment.
still, the recommendation should be %% I think
There was a problem hiding this comment.
Fair enough, I was trying to signal that it worked for ScalaJS as well, but maybe that is implied enough to change. And it is likely that ScalaJS folks will figure that out where a newcomer who isn't familiar with '%%%' might get confused
This ship has probably sailed, but FYI |
|
I think we might be able to revert then. |
remove core dependency auto-add from sbt plugin
Closes #34.
The issue was that the sbt plugin was auto-adding the
smithy4s-coredependency. This worked in all cases except for Scala JS since that would require the use of%%%. We could have updated the plugin to use%%%, but that would require the Scala JS SBT plugin be present on all projects using it, which we do not want to require.