Don't raise 500 when path is too short #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Dec 23, 2021
Baccata
reviewed
Dec 23, 2021
|
|
||
| object MatchPathSpec extends FunSuite { | ||
| object MatchPathSpec extends SimpleMutableIOSuite with Checkers { |
There was a problem hiding this comment.
Small nitpick but SimpleMutableIOSuite is aliased as SimpleIOSuite in weaver.
There was a problem hiding this comment.
right, Metals doesn't help with alias suggestions 😅
Baccata
approved these changes
Dec 23, 2021
Baccata
added a commit
that referenced
this pull request
May 10, 2022
Don't raise 500 when path is too short
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual reproduction (before this change):
Start pizza service, send a request to
/. This will fail with a 500 (index out of bounds: i = 0, array size = 0) regardless of the backend, as long as it usesHttpEndpoint.matches.