Derive http endpoints from hints #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This derives the HttpEndpoint instance associated to an Endpoint, by searching smithy.api.Http in the the Endpoint's hints, and compiling the found data to the correct interface, by means of Schematic. The rationale is the following : 1. allow for dynamically instantiated service to have HttpService without any bespoke processing. 2. open the door for splitting the http package away from the core module
kubukoz
reviewed
Jan 12, 2022
| with schematic.StubSchematic[PathEncode.Make] { | ||
|
|
||
| def default[A]: PathEncode.Make[A] = PathEncode.Make.noop | ||
| def document: PathEncode.Make[Document] = PathEncode.Make.noop |
There was a problem hiding this comment.
nah, the StubSchematic is not smithy specific (we should have one really), but Document is
There was a problem hiding this comment.
but we do have one, smithy4s.StubSchematic is a thing
There was a problem hiding this comment.
hah, forgot about it. Thanks !
|
|
||
| object PathParsingSpec extends weaver.FunSuite { | ||
|
|
||
| test("Parse path pattern into path segments") { |
There was a problem hiding this comment.
I think it's worth having a unit test that verifies how a specific operation encodes to a HttpEndpoint. And maybe a couple examples for paths alone
There was a problem hiding this comment.
For sure. Not sure I'll have much time this week (I already spent much more time on this today than I should have)
lewisjkl
approved these changes
Jan 12, 2022
kubukoz
reviewed
Jan 14, 2022
modules/core/test/src/smithy4s/http/internals/PathParsingSpec.scala
Outdated
Show resolved
Hide resolved
modules/core/test/src/smithy4s/http/internals/PathParsingSpec.scala
Outdated
Show resolved
Hide resolved
kubukoz
approved these changes
Jan 14, 2022
Baccata
added a commit
that referenced
this pull request
May 10, 2022
* Derive HttpEndpoint from Hint instead of relying on subtyping This derives the HttpEndpoint instance associated to an Endpoint, by searching smithy.api.Http in the the Endpoint's hints, and compiling the found data to the correct interface, by means of Schematic. The rationale is the following : 1. allow for dynamically instantiated service to have HttpService without any bespoke processing. 2. open the door for splitting the http package away from the core module Also : * AlsRemove uri-specific methods from core package object * Fix URIEncoderDecoder to actually do uri encoding Co-authored-by: Jakub Kozłowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive HttpEndpoint from Hint instead of relying on subtyping
This derives the HttpEndpoint instance associated to an Endpoint, by searching smithy.api.Http in the the Endpoint's hints, and compiling the found data to the correct interface, by means of Schematic.
The rationale is the following :