add support for transforms in codegen #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
reviewed
Jan 14, 2022
| @@ -27,7 +27,8 @@ object DumpModelCommand { | |||
| val options = ( | |||
| specsArgs, | |||
| repositoriesOpt.map(_.getOrElse(Nil)), | |||
| dependenciesOpt.map(_.getOrElse(Nil)) | |||
| dependenciesOpt.map(_.getOrElse(Nil)), | |||
| transformersOpt.map(_.getOrElse(Nil)) | |||
kubukoz
approved these changes
Jan 14, 2022
|
Curious, what's the usecase for this? |
Though I imagine there are a multitude of uses, the reason for doing this now is to make Smithy4s capable of recognizing shapes/traits defined in a separate protocol. For example, if another protocol (defined in a different repo) also defines a discriminated union trait and we want it to be treated the same was as the smithy4s.api#discriminated trait. With this feature, we can implement a transformer which will change all instances of that discriminated to the smithy4s one. We have this situation more or less in an internal use case. |
Baccata
approved these changes
Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for applying transformers from artifacts in codegen.
The argument
transformersin the codegen args is for specifying the names of each transformer that should be applied.