-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add quickstart guide to docs #62
Conversation
can be removed since smithy4s-http4s brings this in transitively
"com.disneystreaming.smithy4s" %% "smithy4s-http4s" % smithy4sVersion.value, | ||
"com.disneystreaming.smithy4s" %% "smithy4s-http4s-swagger" % smithy4sVersion.value, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So technically, smithy4s-http4s-swagger
brings in smithy4s-http4s
transitively, should we still include both here? My gut says we should leave both.. but wanted to get other thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I don't care much about explicit dependencies, transitive is fine for me - I'd leave just the one that takes in all the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of this doc, I'd rather keep both.
LGTM, what do you think about also showing a client? Maybe a simple main class (IOApp) that hits a single endpoint? |
Yeah that's a good idea, I think it'd be nice to call out that it can do clients right up front like that. |
What I added is based off a simple project I created here: https://github.com/lewisjkl/smithy4s-minimal-example
Happy to move that project into this repo as an example if we want to.