-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove customBuilds, nixos-generate has --flake #436
Conversation
Nice. I had to work around |
44b7866
to
7769225
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏗️
I used to use I'm using this PR and the latest commit of nixos-generators. I used |
75f4dce
to
2f6bcd3
Compare
The I was able to build an iso with my host, and it seems like it includes my entire hosts closure in the iso. I think the |
I can only find |
Also remove https://github.com/Pacman99/digga/blob/2f6bcd38f148a8ffc367400de532f070a0a74294/flake.nix#L51 since we're not depending on nixos-generators for customBuilds. |
bors try |
tryBuild failed: |
2f6bcd3
to
4540e9a
Compare
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
170dbe4
to
b1fade4
Compare
This should be ready to merge with NixOS/nixpkgs#166148 in which should fix @danielphan2003's error Users will need to update their own nixpkgs input for the feature. |
b1fade4
to
6ee221b
Compare
6ee221b
to
51d8ca3
Compare
nixos-generators now has --flake support, so theres no reason for us to export all the builds here. Lets just offload this responsibility to nixos-generators.
Somewhat blocked by nix-community/nixos-generators#138, so that we don't need to make our hosts overridable.