Skip to content
This repository was archived by the owner on Sep 12, 2018. It is now read-only.

Automate maintenance for AUTHORS with update-copyright #669

Merged
merged 3 commits into from
Dec 2, 2014

Conversation

wking
Copy link
Contributor

@wking wking commented Oct 31, 2014

I mentioned this when @dmp42 wished for an automated way to maintain
AUTHORS in #667 1. I thought I'd submit my suggestion as a pull
request since that's probably easier to review than working through
the README on PyPI ;).

wking added 3 commits October 31, 2014 11:39
Use my external update-copyright package [1] to maintain the AUTHORS
file.  Don't maintain the copyright blurbs though, since this project
sticks to:

  Copyright (c) 2014 Docker.
  <Apache blurb>

and doesn't list the file's individual contributors.

[1]: http://pypi.python.org/pypi/update-copyright/
The syntax is described in the MAPPING AUTHORS section of
git-shortlog(1).  I looked for oddities and obvious duplicates in the
list of all commit authors, and added entries here that looked
reasonable to me.  When someone used multiple email addresses, I've
chosen to standardize on whichever address they used for their last
commit.  I haven't contacted any of these folks to confirm my choices.
@dmp42
Copy link
Contributor

dmp42 commented Oct 31, 2014

Love it :)

Can I ask for a case-insensitive result?

Also curous about how this compares with https://github.com/docker/docker/blob/master/hack/generate-authors.sh ?

@wking
Copy link
Contributor Author

wking commented Oct 31, 2014

On Fri, Oct 31, 2014 at 01:21:45PM -0700, Olivier Gambier wrote:

Also curous about how this compares with
https://github.com/docker/docker/blob/master/hack/generate-authors.sh
?

That's doing the same thing, and is probably a better choice (as a
lighter dependency you can just copy into your repository). You'll
probably just want to cherry-pick the .mailmap from this PR, and use
-f/--ignore-case to get your case-insensitive sort.

We can revisit update-copyright if/when you want to list contributing
authors or auto-bump the year ranges in your in-file copyright blurbs
;).

@wking
Copy link
Contributor Author

wking commented Oct 31, 2014

On Fri, Oct 31, 2014 at 01:27:55PM -0700, W. Trevor King wrote:

We can revisit update-copyright if/when you want to list contributing
authors or auto-bump the year ranges in your in-file copyright blurbs
;).

Or if you want to credit authors of content that was copy-pasted into
this repository without it's associated history (e.g. @tianon, if
whoever copies generate-authors.sh over doesn't list him as the
author of that commit).

@dmp42 dmp42 added this to the GO-RC milestone Nov 5, 2014
@stevvooe
Copy link
Contributor

@dmp42 Should this still be marked Next-Generation? Are you going to cherry-pick this into the next-generation branch?

@dmp42
Copy link
Contributor

dmp42 commented Nov 13, 2014

@stevvooe yes I probably want the same script that docker core uses - will sort that one later this week.

@stevvooe
Copy link
Contributor

stevvooe commented Dec 2, 2014

@dmp42 @wking Let's merge this PR into master and make a new PR for the next-generation branch.

@dmp42
Copy link
Contributor

dmp42 commented Dec 2, 2014

Agreed.
Thanks @wking!

dmp42 added a commit that referenced this pull request Dec 2, 2014
Automate maintenance for AUTHORS with update-copyright
@dmp42 dmp42 merged commit 99f7d0c into docker-archive:master Dec 2, 2014
@stevvooe stevvooe removed this from the GO-RC milestone Dec 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants