This repository was archived by the owner on Sep 26, 2021. It is now read-only.
Improve customization for unattended installation #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… them from being controlled in an unattended installation. Instead only disable the checkbox if the component must be installed (even in this case the default can be overridden for unattended installation, but for the average user installation will be forced, as it should be since these are required for other components to function) Signed-off-by: Erik M. Bray <[email protected]>
embray
force-pushed
the
custom-install
branch
from
8e06030 to
744cd2f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #322 by making it easier to control via the
/COMPONENTScommand-line option to the installer which optional components are installed.Because the
DockerandDockerMachinecomponents are markedfixed, these components cannot be deselected with the/COMPONENTSoption which I think is fine. When it comes to other semi-optional components (namely VirtualBox and Git) it's a little trickier to decide what to do.In this case I decided that if VBox or Git need to be installed, then their checkboxes will be grayed out, so an average user running the installer will be forced to select them (as they are selected by default). However, this does not stop the
/COMPONENTSparameter from changing these selections, which still give administrators who (ostensibly) know what they're doing some control over what gets installed by the installer. This was not the case when the.Checkedproperty was being set manually, which would always override the selection via/COMPONENTS.Open to other ideas as well but I think this is an improvement. Unfortunately I can't find any way in Inno Setup to query what was explicitly selected or deslected via
/COMPONENTS.