Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run upstream tests on images in CI here #555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tianon
Copy link
Member

@tianon tianon commented Feb 14, 2025

This runs upstream's dist test which is roughly go test std cmd.

Fixes #552

This runs upstream's `dist test` which is roughly `go test std cmd`.
@tianon
Copy link
Member Author

tianon commented Feb 14, 2025

Ouch, I knew they'd be rough, but 10-11 minutes is even heavier than I was picturing.

@tianon
Copy link
Member Author

tianon commented Feb 15, 2025

On the upside, total "wall clock" for https://github.com/docker-library/golang/actions/runs/13339366508 (current master) is ~23m 56s and https://github.com/docker-library/golang/actions/runs/13338265228 (this PR) is ~30m 36s.

@yosifkit
Copy link
Member

I agree to adding tests to ensure that the go binaries work as expected in the container environment but the comparison to the most recent run on master is not quite accurate since it took so long because of the Windows 2025 failures (cancelled last week in 22m 59s). Looking at runs before that like https://github.com/docker-library/golang/actions/runs/13297417083 and the complete wall clock is ~14 minutes but greatly slowed by pulling windows images 😢. It's complicated. 🫤

I think the biggest extra slowdown is the serial testing of 1.24 and then tip, though I am unsure if running multiple dist test at the same time will be significantly faster since it is CPU heavy. But, running the DOI tests in parallel is not something we can change in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add go test std to image tests
2 participants