Slightly different date value to get updates Monday
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I intended for this to update every Monday (with "the last week's changes", including the weekend), but `last monday` doesn't match my intent until *Tuesday*, so this fixes that boundary condition by using `last sunday` instead, one second to midnight, and using date math to add a second. I also found that even with `--utc`, I had to explicitly specify `UTC` in my string or it would be off by an hour.
|
(this doesn't change |
yosifkit
approved these changes
Feb 25, 2025
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 3, 2025
Changes: - docker-library/golang@198ea08: Update tip to tip-20250301, commit b199d9766a8957c686ece568483586f08fc9a8b4 - docker-library/golang@26dd321: Merge pull request docker-library/golang#557 from infosiftr/monday - docker-library/golang@e534186: Slightly different `date` value to get updates Monday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intended for this to update every Monday (with "the last week's changes", including the weekend), but
last mondaydoesn't match my intent until Tuesday, so this fixes that boundary condition by usinglast sundayinstead, one second to midnight, and using date math to add a second.I also found that even with
--utc, I had to explicitly specifyUTCin my string or it would be off by an hour.