public attestation on-chain module #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bddap
commented
Dec 23, 2020
| @@ -28,6 +28,9 @@ pub struct Blob { | |||
| pub trait Trait: system::Trait + did::Trait { | |||
| /// Blobs larger than this will not be accepted. | |||
| type MaxBlobSize: Get<u32>; | |||
| /// The cost charged by the network to store a single byte in chain-state for the life of the | |||
| /// chain. | |||
| type StorageWeight: Get<Weight>; | |||
There was a problem hiding this comment.
Might as well add this to the blob module as well.
bddap
commented
Dec 23, 2020
| @@ -313,10 +315,12 @@ impl revoke::Trait for Runtime {} | |||
|
|
|||
| parameter_types! { | |||
| pub const MaxBlobSize: u32 = 1024; | |||
| pub const StorageWeight: Weight = 1100; | |||
There was a problem hiding this comment.
This is the same value we were using in the blob module before.
bddap
commented
Dec 23, 2020
| @@ -103,6 +104,7 @@ pub enum StateChange { | |||
| RemoveRegistry(revoke::RemoveRegistry), | |||
| Blob(blob::Blob), | |||
| MasterVote(master::Payload), | |||
| Attestation((did::Did, attest::Attestation)), | |||
There was a problem hiding this comment.
Did is explicit when attesting.
bddap
changed the title
nmrshll
force-pushed
the
public-attestation
branch
from
0ebf625 to
747e231
Compare
nmrshll
force-pushed
the
public-attestation
branch
from
747e231 to
346e1ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the on-chain component for public attestations as proposed in https://github.com/docknetwork/planning/blob/37651baffc3d28cdb961b4dddd6e97014d34ff90/rfc/0014-public-attestation.md#on-chain-component .
The nonce-like value (called "priority" in this module) used for replay protection of DID signatures is
Compact<>encoded. The node-client (SDK) will need to test that priority values over 255 are encoded and decoded properly and work as expected.