WIP: Support version 2.0 of the MongoDB driver #2683
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
support-driver-2.0
branch
from
3bc60e1 to
11c9306
Compare
|
Note: static analysis will be red until we figure out how to best handle multiple driver versions in Psalm and PHPStan. |
alcaeus
force-pushed
the
support-driver-2.0
branch
from
2d78bbb to
f2ac6c4
Compare
GromNaN
reviewed
Mar 6, 2025
| @@ -39,7 +40,7 @@ jobs: | |||
| - dependencies: "lowest" | |||
| php-version: "8.1" | |||
| mongodb-version: "5.0" | |||
| driver-version: "1.17.0" | |||
| driver-version: "1.20.0" | |||
There was a problem hiding this comment.
Suggested change
| driver-version: "1.20.0" | |
| driver-version: "1.21.1" |
| @@ -22,15 +22,15 @@ | |||
| ], | |||
| "require": { | |||
| "php": "^8.1", | |||
| "ext-mongodb": "^1.17", | |||
| "ext-mongodb": "^1.20 || ^2.0", | |||
There was a problem hiding this comment.
Suggested change
| "ext-mongodb": "^1.20 || ^2.0", | |
| "ext-mongodb": "^1.21 || ^2.0", |
| "doctrine/cache": "^1.11 || ^2.0", | ||
| "doctrine/collections": "^1.5 || ^2.0", | ||
| "doctrine/event-manager": "^1.0 || ^2.0", | ||
| "doctrine/instantiator": "^1.1 || ^2", | ||
| "doctrine/persistence": "^3.2", | ||
| "friendsofphp/proxy-manager-lts": "^1.0", | ||
| "jean85/pretty-package-versions": "^1.3.0 || ^2.0.1", | ||
| "mongodb/mongodb": "^1.17.0", | ||
| "mongodb/mongodb": "^1.20 || ^2.0@dev", |
There was a problem hiding this comment.
Suggested change
| "mongodb/mongodb": "^1.20 || ^2.0@dev", | |
| "mongodb/mongodb": "^1.21.1 || ^2.0@dev", |
alcaeus
force-pushed
the
support-driver-2.0
branch
from
78e8a97 to
7d1e4ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The 2.0 release of the PHP driver will mainly remove deprecated functionality, which was already removed in a previous pull request. This PR adds a separate build job to test the ODM with version 2.0 of the extension and library to ensure everything continues to work. The goal is to support both versions of the extension at the same time to make upgrading easier.