-
-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Support version 2.0 of the MongoDB driver #2683
base: 2.11.x
Are you sure you want to change the base?
Conversation
3bc60e1
to
11c9306
Compare
Note: static analysis will be red until we figure out how to best handle multiple driver versions in Psalm and PHPStan. |
2d78bbb
to
f2ac6c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calls to selectDatabase
and selectCollection
should be replaced with getDatabase
and getCollection
.
@@ -39,7 +40,7 @@ jobs: | |||
- dependencies: "lowest" | |||
php-version: "8.1" | |||
mongodb-version: "5.0" | |||
driver-version: "1.17.0" | |||
driver-version: "1.20.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
driver-version: "1.20.0" | |
driver-version: "1.21.1" |
@@ -22,15 +22,15 @@ | |||
], | |||
"require": { | |||
"php": "^8.1", | |||
"ext-mongodb": "^1.17", | |||
"ext-mongodb": "^1.20 || ^2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ext-mongodb": "^1.20 || ^2.0", | |
"ext-mongodb": "^1.21 || ^2.0", |
"doctrine/cache": "^1.11 || ^2.0", | ||
"doctrine/collections": "^1.5 || ^2.0", | ||
"doctrine/event-manager": "^1.0 || ^2.0", | ||
"doctrine/instantiator": "^1.1 || ^2", | ||
"doctrine/persistence": "^3.2", | ||
"friendsofphp/proxy-manager-lts": "^1.0", | ||
"jean85/pretty-package-versions": "^1.3.0 || ^2.0.1", | ||
"mongodb/mongodb": "^1.17.0", | ||
"mongodb/mongodb": "^1.20 || ^2.0@dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mongodb/mongodb": "^1.20 || ^2.0@dev", | |
"mongodb/mongodb": "^1.21.1 || ^2.0@dev", |
78e8a97
to
7d1e4ff
Compare
Summary
The 2.0 release of the PHP driver will mainly remove deprecated functionality, which was already removed in a previous pull request. This PR adds a separate build job to test the ODM with version 2.0 of the extension and library to ensure everything continues to work. The goal is to support both versions of the extension at the same time to make upgrading easier.