Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cleanup scrutinizer issues #37

Merged
merged 4 commits into from
May 6, 2018

Conversation

redthor
Copy link
Contributor

@redthor redthor commented May 3, 2018

Scrutinizer has a lot of errors due to incorrectly identifying classes via typehint/docblock.

Sorry, this includes the previous PR #36 - can re-make this if we don't choose to merge #36.

@redthor
Copy link
Contributor Author

redthor commented May 3, 2018

This fixes 33 scrutinizer issues.

@redthor redthor requested a review from caciobanu May 3, 2018 12:37
@caciobanu
Copy link
Member

LGTM

@redthor redthor merged commit 0607e7e into doesntmattr:master May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants