Skip to content

Remove add content button #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2017
Merged

Remove add content button #33

merged 1 commit into from
Nov 29, 2017

Conversation

islamovic
Copy link
Contributor

@islamovic islamovic commented Nov 21, 2017

Fixes issue #.
  • This pull request follows the coding standards
This PR changes:
  • remove add content button that suspend the application

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
remove add content button that suspend the application
@dogo
Copy link
Owner

dogo commented Nov 21, 2017

@islamovic
Could you please give me more details about the change?

@islamovic
Copy link
Contributor Author

@dogo This button cause a problem while sliding the navigation menu. There is a problem happens when slide the menu just a bit. the menu stops sliding and this button start to take over the main screen and add it self above all layers and the app look likes it's freezes and no response.

I think the problem will be solved if we solved the main issue when the user slide the menu just a little bit and if he release the menu should continue all the way to right or to the left but don't stop for sure.
But for now i removed this button because i don't know why we should add it.

@dogo
Copy link
Owner

dogo commented Nov 29, 2017

hum, after some investigation and testing with the described scenario and the regular ones seems fine remove. Thanks @islamovic

@dogo dogo merged commit c46f22b into dogo:develop Nov 29, 2017
@dogo dogo mentioned this pull request Nov 29, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants