Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow renaming views with RENAME TABLE statement #1741

Merged
merged 5 commits into from
May 2, 2023
Merged

allow renaming views with RENAME TABLE statement #1741

merged 5 commits into from
May 2, 2023

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented May 1, 2023 •
edited
Loading

This is the same PR as #1712 (it was reverted)

  • allows renaming views using RENAME TABLE statement
  • fails on renaming views using ALTER TABLE ... RENAME ... statement

@jennifersp jennifersp requested a review from fulghum May 1, 2023 19:03
fulghum
fulghum approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. Good catch on the new ALTER TABLE case. Looks great! 🚢

@jennifersp jennifersp merged commit bdf7604 into main May 2, 2023
@jennifersp jennifersp deleted the jennifer/view-rename-2 branch May 2, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @fulghum