Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small aggregation perf improvements #1781

Merged
merged 4 commits into from
May 18, 2023
Merged

Small aggregation perf improvements #1781

merged 4 commits into from
May 18, 2023

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented May 17, 2023 •
edited
Loading

  • We used to make a new error object for every cache.Get() miss. Use shared object instead.
  • Add reuse pool for collation weight buffers rather than making thousands of [4]byte.

before:
image

after:
image

zachmu
zachmu approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@max-hoffman max-hoffman merged commit cdfb293 into main May 18, 2023
@max-hoffman max-hoffman deleted the max/agg-perf branch May 18, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-hoffman @zachmu