Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim spaces and empty statements to the right in planbuilder.Parse #1823

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

reusee
Copy link
Contributor

@reusee reusee commented Jun 9, 2023

No description provided.

@timsehn
Copy link
Contributor

timsehn commented Jun 9, 2023

Thanks for the contribiution. @fulghum or @zachmu will review it today.

At first glance, a why in the PR description and maybe a test of this new behavior would be ncie.

@reusee reusee changed the title Trim all right-most semicolons with strings.TrimRight in planbuilder.Parse Trim spaces and empty statements to the right in planbuilder.Parse Jun 9, 2023
@zachmu
Copy link
Member

zachmu commented Jun 12, 2023

This looks fine to me but Max should take a look to see if I'm missing something obvious.

Main thing is that this should be symmetric between both the places in the code base we parse, and this only hits one.

@zachmu zachmu requested a review from max-hoffman June 12, 2023 17:00
@max-hoffman
Copy link
Contributor

This edits an in-progress rewrite with only partial testing coverage. This PR should copy the changes to the equivalent lines in sql/parse/parse.go. If those changes pass tests then OK with me.

@reusee
Copy link
Contributor Author

reusee commented Jun 12, 2023

This edits an in-progress rewrite with only partial testing coverage. This PR should copy the changes to the equivalent lines in sql/parse/parse.go. If those changes pass tests then OK with me.

Done. But some test cases in sql/parse/parse_test.go need updates.

Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for the contribution!

@max-hoffman max-hoffman merged commit d71df24 into dolthub:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants