Skip to content

Various small parser improvements #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 21, 2023
Merged

Various small parser improvements #249

merged 5 commits into from
Jun 21, 2023
+7,508 −7,398

Conversation

fulghum
Copy link

@fulghum fulghum commented Jun 21, 2023 •
edited
Loading

Various small parser improvements:

  • Allow column definitions to use the MySQL INVISIBLE keyword. The implementation still ignores the INVISIBLE keyword, but it will no longer cause a parser error.
  • Support DOUBLE and FLOAT in the CAST and CONVERT functions.
  • Allow a trigger body to be a single CALL statement.

@fulghum fulghum requested a review from zachmu as a code owner June 21, 2023 19:28
@fulghum fulghum changed the title Parser support for the INVISIBLE keyword Various small parser improvements Jun 21, 2023
@fulghum fulghum requested a review from jycor June 21, 2023 20:34
jycor
jycor approved these changes Jun 21, 2023
View reviewed changes
Copy link

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit a7d3799 into main Jun 21, 2023
@fulghum fulghum mentioned this pull request Jun 21, 2023
Merged
@Hydrocharged Hydrocharged deleted the fulghum/cleanup branch February 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor

@zachmu zachmu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fulghum @jycor