Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add single quote when use pattern with filters #2206

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Add single quote when use pattern with filters #2206

merged 2 commits into from
Nov 29, 2022

Conversation

erlangxk
Copy link
Contributor

No description provided.

AndreyAkinshin
AndreyAkinshin requested changes Nov 29, 2022
View reviewed changes
Copy link
Member

@AndreyAkinshin AndreyAkinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlangxk, you have used the wrong type of quotes (‘’ instead of '')

@erlangxk
Copy link
Contributor Author

very weried, I don't know what is that single quote I used in the first commit. maybe I use some non-English input method that time.

@AndreyAkinshin AndreyAkinshin merged commit 926e376 into dotnet:docs-stable Nov 29, 2022
@AndreyAkinshin AndreyAkinshin added this to the v0.13.3 milestone Nov 29, 2022
@AndreyAkinshin
Copy link
Member

@erlangxk thanks!

AndreyAkinshin pushed a commit that referenced this pull request Jan 5, 2023
@erlangxk @AndreyAkinshin
Add single quote when use pattern with filters (#2206)
ea0eb2f 
* Add single quote when use pattern with filters

* use the correct single quote
@AndreyAkinshin AndreyAkinshin modified the milestones: v0.13.3, v0.13.4 Jan 5, 2023
@AndreyAkinshin
Copy link
Member

@erlangxk I just realized that this PR was to the docs-stable branch. According to the current workflow, all the documentation changes should be merged to the master branch and cherry-picked to the docs-stable. Once another release version is published, docs-stable is moving to the latest master. This allows us to maintain a nicer git history and track changes in a more transparent way. Sorry, but I lost your commit in v0.13.3. Just cherry-picked it to master, it will be included in v0.13.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

Assignees
No one assigned
Labels
Area:Documentation
Projects
None yet
Milestone
v0.13.4
Development

Successfully merging this pull request may close these issues.
2 participants
@erlangxk @AndreyAkinshin