use least supported framework #355
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperk81
force-pushed
the
netcoreapp-eol
branch
from
a4b9125 to
b863bee
Compare
kasperk81
force-pushed
the
netcoreapp-eol
branch
from
b863bee to
e861702
Compare
kasperk81
commented
Aug 26, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <OutputType>Library</OutputType> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
| <TargetFramework>net6.0-windows</TargetFramework> | |||
| <UseWindowsForms>true</UseWindowsForms> | |||
There was a problem hiding this comment.
KerbDumpCore.csproj
<OutputType>Library</OutputType>
"core library" project shouldn't have dependency on windows forms. all its dependents are tied to windows
kasperk81
commented
Aug 26, 2023
| @@ -41,4 +41,10 @@ | |||
| <ProjectReference Include="..\Samples\KerbDumpCore\KerbDumpCore.csproj" /> | |||
There was a problem hiding this comment.
referencing "samples" project outside the sample dir looks weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core#lifecycle