API diff between .NET 10 Preview 2 and .NET 10 Preview 3 #9821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
ViktorHofer,
ericstj,
kouvel,
Tanya-Solyanik,
mangod9 and
a team
carlossanlop
requested review from
rbhanda,
leecow and
victorisr
as code owners
carlossanlop
commented
Mar 25, 2025
...w/preview3/api-diff/Microsoft.NETCore.App/10.0-preview3_System.ComponentModel.Annotations.md
Show resolved
Hide resolved
.../preview3/api-diff/Microsoft.WindowsDesktop.App/10.0-preview3_System.Windows.Forms.Design.md
Show resolved
Hide resolved
bartonjs
reviewed
Mar 25, 2025
...review/preview3/api-diff/Microsoft.NETCore.App/10.0-preview3_System.Security.Cryptography.md
Outdated
Show resolved
Hide resolved
|
ComponentModel annotations (with the suggestion) and Diagnostics LGTM! |
|
System.Threading LGTM |
|
Crypto and ASN1 LGTM |
JeremyKuhne
approved these changes
Mar 27, 2025
|
WinForms lgtm |
Comment on lines
+14
to
+21
| + public int? BlinkRate { get; set; } | ||
| - public System.Windows.Forms.ErrorBlinkStyle BlinkStyle { get; set; } | ||
| + public System.Windows.Forms.ErrorBlinkStyle? BlinkStyle { get; set; } | ||
| - public bool HasErrors { get; } | ||
| + public bool? HasErrors { get; } | ||
| - public virtual bool RightToLeft { get; set; } | ||
| + public virtual bool? RightToLeft { get; set; } | ||
| + protected override void Dispose(bool? disposing); |
There was a problem hiding this comment.
all those ? doesn't feel right
https://github.com/dotnet/winforms/blame/release/10.0-preview3/src/System.Windows.Forms/System/Windows/Forms/ErrorProvider/ErrorProvider.cs#L114
especially Dispose(bool? disposing)
There was a problem hiding this comment.
@JeremyKuhne @Tanya-Solyanik can you please confirm the nullability changes?
There was a problem hiding this comment.
@carlossanlop Yeah, that's wrong. The code doesn't have that, so I'm not sure why this showed up.
There was a problem hiding this comment.
The SetDataAsJson overload removal is right though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo area owners:
Libraries area owners:
New tool to generate diffs!
I have an open PR with the new tool we'll be using from now on to generate these API diffs: dotnet/sdk#46425
If you see any bugs, or if you don't see any APIs that should've showed up, please let me know.
Main differences with the old tool:
addandremoveaccessors.