-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Redaction and Compliance docs #45373
Conversation
@IEvangelist this is for the data classification and redaction extensions in dotnet/extensions. Thank you @mariamgerges for taking this on! Question I have, is location within the toc -- I would expect it to be under Runtime Libraries Overview, but want to hear some opinions from the folks here. |
Hi @dariusclay - yeah, I agree it should be under the Runtime libraries TOC instead. This is neither diagnostics nor instrumentation. I'll review this in a bit. Great job @mariamgerges |
I moved the files and updated the Runtime libraries TOC. |
@IEvangelist The OPS status checker build step is failing, and I don't understand why, can you help? |
It's a safety net, we have that check in place to fail when the OpenPublishing.Build check has warnings. I don't think any of these are related to your PR, so you're good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, lots of nits to help improve this already awesome content. Let's get these suggestions in and I'll do another small review.
Just a quick heads up @mariamgerges - when you use tabs, you need specify also close them out with a |
This is really shaping up nicely. I think we might want to make a few more tweaks. We could benefit from an Overview article that speaks to the benefits of these libraries and their overall compliance objectives. Then, in the compliance article, let's pivot a bit, moving the Redaction bits into the redaction article, and shifting this to be more about data classification. Then the TOC would look more like this:
|
I updated the docs, created an overview article and a separate doc for data classification and moved the redaction bits to the data redaction doc and updated the TOC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better, we have a few more things to improve then we can ship this!
This PR adds documentation pages for redaction and compliance.
Internal previews