Skip to content

Catch OperationCanceledException instead of TaskCanceledException #9366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 12, 2025

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 3, 2023

Fast-follow to #9362.
Users should catch OperationCanceledException instead of TaskCanceledException (see #9362 (comment)).

Hide whitespace changes in diff.

@gewarren gewarren requested a review from a team as a code owner October 3, 2023 23:28
@ghost ghost assigned gewarren Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fast-follow to #9362.
Users should catch OperationCanceledException instead of TaskCanceledException (see #9362 (comment)).

Hide whitespace changes in diff.

Author: gewarren
Assignees: gewarren
Labels:

area-System.Net.Http

Milestone: -

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@gewarren gewarren changed the title Clean up op canceled exceptions Catch OperationCanceledException instead of TaskCanceledException Mar 5, 2024

This comment was marked as outdated.

@gewarren gewarren requested a review from a team May 10, 2024 15:33
@adegeo
Copy link
Contributor

adegeo commented Aug 29, 2024

@gewarren This one has conflicts

@gewarren
Copy link
Contributor Author

@adegeo Could you review again?

This comment was marked as outdated.

Copy link

Learn Build status updates of commit 8e33fc8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View
xml/System.Net.Security/NegotiateStream.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren requested a review from CarnaViire February 12, 2025 22:11
@gewarren gewarren enabled auto-merge (squash) February 12, 2025 22:11

This comment was marked as outdated.

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

Learn Build status updates of commit 43d8ee0:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View
xml/System.Net.Security/NegotiateStream.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 7e81a1b:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View
xml/System.Net.Security/NegotiateStream.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 8edef8b into dotnet:main Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants