Skip to content

Improve Assembly docs #9679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 15, 2024
Merged

Improve Assembly docs #9679

merged 10 commits into from
Mar 15, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 6, 2024

Summary

  • Note that Assembly.Load creates assembly in isolated load context
  • Move .NET-neutral content to be first in the remarks
  • Generalize description of BadImageFormatException (delete explicit .NET Framework 2.0 references)
  • Delete .NET Framework 1.x content

Follow up on dotnet/runtime#99203

@jkotas jkotas requested a review from a team as a code owner March 6, 2024 03:36
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 6, 2024
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jkotas
Copy link
Member Author

jkotas commented Mar 6, 2024

cc @agocke @elinor-fung

@jkotas jkotas requested a review from elinor-fung March 6, 2024 03:38
Copy link

Learn Build status updates of commit b9aa9a1:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View
xml/System/AppDomain.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Mar 6, 2024
Copy link

Learn Build status updates of commit e393abf:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View
xml/System/AppDomain.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Co-authored-by: Genevieve Warren <[email protected]>
Copy link

Learn Build status updates of commit c985729:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View
xml/System/AppDomain.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@jkotas jkotas merged commit a7a3afa into dotnet:main Mar 15, 2024
3 checks passed
@jkotas jkotas deleted the assembly-docs branch March 15, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants