Skip to content

Improve System.Guid and System.Type.Guid documentation #9715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2024
Merged

Improve System.Guid and System.Type.Guid documentation #9715

merged 4 commits into from
Mar 15, 2024

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 13, 2024

Summary

  • Clarify that Type.Guid is COM-interop specific
  • Delete COM-interop specific sample from System.Guid. This sample is not directly relevant to Guid type and there are other similar samples on GuidAttribute.

Contributes to dotnet/runtime#99459

@jkotas
Import System.Guid and System.Type.Guid documentation
b8ef7a0 
- Clarify that Type.Guid is COM-interop specific
- Delete COM-interop specific sample from System.Guid. This sample is
  not directly relevant to Guid type and there are other similar samples
  on GuidAttribute.
@jkotas jkotas requested a review from a team as a code owner March 13, 2024 06:07
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime

@jkotas jkotas mentioned this pull request Mar 13, 2024
Open
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit b8ef7a0:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Guid.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

gewarren
gewarren approved these changes Mar 15, 2024
View reviewed changes
@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 22013ba:

✅ Validation status: passed

File Status Preview URL Details
xml/System/Guid.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 654d78a:

✅ Validation status: passed

File Status Preview URL Details
snippets/cpp/VS_Snippets_CLR/Guid/CPP/Guids.cpp ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System/Guid/Overview/Guids.cs ✅Succeeded n/a (file deleted or renamed)
snippets/csharp/System/Guid/Overview/Project.csproj ✅Succeeded n/a (file deleted or renamed)
snippets/fsharp/System/Guid/Overview/fs.fsproj ✅Succeeded n/a (file deleted or renamed)
snippets/fsharp/System/Guid/Overview/Guids.fs ✅Succeeded n/a (file deleted or renamed)
snippets/visualbasic/VS_Snippets_CLR/Guid/VB/Guids.vb ✅Succeeded n/a (file deleted or renamed)
xml/System/Guid.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@jkotas
Copy link
Member Author

jkotas commented Mar 15, 2024

@gewarren Thank you for reviewing!

@jkotas jkotas merged commit 717df1d into dotnet:main Mar 15, 2024
3 checks passed
@jkotas jkotas deleted the guid branch March 15, 2024 19:57
@jkotas jkotas changed the title Import System.Guid and System.Type.Guid documentation Improve System.Guid and System.Type.Guid documentation Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees

@jkotas jkotas

Labels
area-System.Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkotas @gewarren