Skip to content

.NET 9 Preview 2 (Core and Desktop) #9717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Mar 14, 2024

Conversation

gewarren
Copy link
Contributor

Contributes to dotnet/docs#9587

Commits are separated by namespace.

This comment was marked as outdated.

 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=418187&view=results
 source_repo.branch:net9-pre2-core-desktop
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a cursory view and looked at some of the previews. This all LGTM.

You can :shipit: when ready.

This comment was marked as outdated.

@gewarren
Copy link
Contributor Author

I logged https://ceapex.visualstudio.com/Engineering/_workitems/edit/953943 for the inheritdoc suggestions.

@gewarren gewarren enabled auto-merge (squash) March 14, 2024 20:34
Copy link

Learn Build status updates of commit 2f19138:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System/Uri.xml 💡Suggestion View Details
xml/FrameworksIndex/net-9.0.xml ✅Succeeded
xml/FrameworksIndex/windowsdesktop-9.0.xml ✅Succeeded
xml/Microsoft.Extensions.Caching.Memory/CacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/HttpClientFactoryServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptKeyHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptProviderHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptSecretHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeX509ChainHandle.xml ✅Succeeded View
xml/ns-System.Drawing.Imaging.Effects.xml ✅Succeeded View
xml/System.ComponentModel/CustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/DesignerAttribute.xml ✅Succeeded View
xml/System.ComponentModel/EditorAttribute.xml ✅Succeeded View
xml/System.ComponentModel/ICustomTypeDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/PropertyDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/TypeDescriptor.xml ✅Succeeded View
xml/System.Data.Common/DbConnectionStringBuilder.xml ✅Succeeded View
xml/System.Data.Common/DbDataRecord.xml ✅Succeeded View
xml/System.Data/DataRowView.xml ✅Succeeded View
xml/System.Diagnostics/StackTrace.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsPath.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BlackSaturationCurveEffect.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BlurEffect.xml ✅Succeeded View
xml/System.Drawing.Imaging.Effects/BrightnessContrastEffect.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System/Uri.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#IFormattable#ToString(System.String,System.IFormatProvider) for uid: System.Uri.System#IFormattable#ToString(System.String,System.IFormatProvider).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider) for uid: System.Uri.System#ISpanFormattable#TryFormat(System.Span{System.Char},System.Int32@,System.ReadOnlySpan{System.Char},System.IFormatProvider).

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor Author

@BillWagner Could you approve so I can merge it?

@gewarren gewarren merged commit 41abdc1 into dotnet:main Mar 14, 2024
3 checks passed
@gewarren gewarren deleted the net9-pre2-core-desktop-chunked branch March 14, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants