Scaffold uses system's comma separator for HasDefaultValue

[Quietscheente]

Bug description

I have a german Windows 10 and with Scaffold (8.0.8)
a default value set in the database (SQL Server 13.0) with
ALTER TABLE [dbo].[Foo] ADD CONSTRAINT [DF_Foo_weight] DEFAULT ((1.0)) FOR [weight] becomes a entity.Property(e => e.Weight).HasDefaultValue(10.0);
in the DbContext.
If I change the comma separator in the Region settings to "." it is HasDefaultValue(1.0) as expected.

Your code

USE [BIS]
GO

SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

CREATE TABLE [dbo].[Foo](
	[id] [int] IDENTITY(1,1) NOT NULL,	
	[weight] [float] NOT NULL,	
 CONSTRAINT [PK_Foo] PRIMARY KEY CLUSTERED 
(
	[id] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY])
GO

ALTER TABLE [dbo].[Foo] ADD  CONSTRAINT [DF_Foo_weight]  DEFAULT ((1.0)) FOR [weight]
GO

        modelBuilder.Entity<Foo>(entity =>
        {
            entity.Property(e => e.Weight).HasDefaultValue(10.0);
        });

[Table("Foo")]
public partial class Foo
{
    [Key]
    [Column("id")]
    public int Id { get; set; }

    [Column("weight")]
    public double Weight { get; set; }
}

Stack traces

Verbose output

EF Core version

8.0.8

Database provider

No response

Target framework

.NET 8

Operating system

Windows 10

IDE

No response

[ErikEJ]

Please share the full CREATE TABLE statement

[Quietscheente]

I created a minimal example

USE [BIS]
GO

SET ANSI_NULLS ON
GO

SET QUOTED_IDENTIFIER ON
GO

CREATE TABLE [dbo].[Foo](
	[id] [int] IDENTITY(1,1) NOT NULL,	
	[weight] [float] NOT NULL,	
 CONSTRAINT [PK_Foo] PRIMARY KEY CLUSTERED 
(
	[id] ASC
)WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY])
GO

ALTER TABLE [dbo].[Foo] ADD  CONSTRAINT [DF_Foo_weight]  DEFAULT ((1.0)) FOR [weight]
GO

        modelBuilder.Entity<Foo>(entity =>
        {
            entity.Property(e => e.Weight).HasDefaultValue(10.0);
        });

[Table("Foo")]
public partial class Foo
{
    [Key]
    [Column("id")]
    public int Id { get; set; }

    [Column("weight")]
    public double Weight { get; set; }
}

[ErikEJ]

https://github.com/dotnet/efcore/blob/main/src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs#L921C24-L921C42

Looks like this method signature should have been used:

https://learn.microsoft.com/en-us/dotnet/api/system.convert.changetype?view=net-9.0#system-convert-changetype(system-object-system-type-system-iformatprovider)

@roji Happy to submit a PR!

@Quietscheente I have fixed this in the latest daily of EF Core Power Tools

[roji]

@roji Happy to submit a PR!

Sure, that'd be great!

[ErikEJ]

https://github.com/dotnet/efcore/blob/main/test/EFCore.SqlServer.FunctionalTests/Scaffolding/SqlServerDatabaseModelFactoryTest.cs#L3936

[zimaa77]

Would be possible to merge this fix into 8.0.x release?

[ErikEJ]

@zimaa77 The fix is in EF Core Power Tools CLI for EF Core 8