Discover join type FK properties using the same naming convention as when creating them #26221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pilchie For approval |
…hen creating them Fixes #26208
AndriySvyryd
force-pushed
the
Issue26208
branch
from
31d3a71 to
ad1642f
Compare
smitpatel
approved these changes
Oct 1, 2021
|
Approved for EFCore 6.0 GA |
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26208
Description
When an explicit join entity type is used we don't discover the foreign key properties that would have match the name for the shadow properties we created.
Customer impact
Users would need to add additional configuration for the foreign keys, diluting the value of the new simpler
UsingEntityoverloads.How found
Docs writing
Regression
No, this mainly impacts the new
UsingEntityoverloadsTesting
Test for this scenario added in the PR.
Risk
Low, this mainly impacts the new
UsingEntityoverloads. It is a breaking change from RC2 if the shadow FKs were left unconfigured, though this shouldn't be common.