Make IsAsyncData readonly and use collection initializers #35786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request improves code quality by making the IsAsyncData fields readonly and simplifying their initialization with collection initializers.
- Changed IsAsyncData fields to readonly in multiple test files
- Updated array initialization syntax to use collection initializers
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/EFCore.Specification.Tests/Query/NorthwindCompiledQueryTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Relational.Tests/Storage/RelationalDataReaderTest.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Relational.Specification.Tests/Query/NorthwindSqlQueryTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Specification.Tests/ConcurrencyDetectorTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Relational.Specification.Tests/Query/PrecompiledQueryRelationalTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.SqlServer.FunctionalTests/SqlServerValueGenerationScenariosTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Relational.Specification.Tests/Update/StoreValueGenerationTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Specification.Tests/Update/UpdatesTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.CrossStore.FunctionalTests/QueryTest.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Relational.Tests/Storage/RelationalCommandTest.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Relational.Tests/Query/Internal/BufferedDataReaderTest.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Specification.Tests/NonSharedModelTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Specification.Tests/Query/QueryTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Cosmos.FunctionalTests/ReloadTest.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Specification.Tests/BulkUpdates/BulkUpdatesTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Relational.Specification.Tests/Migrations/MigrationsInfrastructureTestBase.cs | Updated IsAsyncData declaration to readonly using collection initializer |
| test/EFCore.Cosmos.FunctionalTests/Storage/CosmosDatabaseCreatorTest.cs | Updated IsAsyncData declaration to readonly using collection initializer |
roji
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small, quality of life, improvement.