Remove support for Signed and Validated qualities #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After looking at usage data for the aka.ms links that back these qualities, it's clear that the only usage is from the tests in the install scripts repo itself. Removing these links has significant benefit to the overall time it takes to run our staging pipelines, as well as overall maintainability.
pavel-purma
approved these changes
Apr 16, 2025
|
We need a docs issue to track the removal as well. |
baronfel
approved these changes
Apr 16, 2025
Can you point me to how this is done (or an existing one I can template off of). Does this need to be in place before this is merged? |
|
@JanProvaznik has already got something going, no worries. He also found a couple of uses of these in the wild - like 5. I'll reach out to those folks today |
baronfel
added a commit
to baronfel/NDesk.Options.Core
that referenced
this pull request
Apr 17, 2025
The 'signed' quality is [being removed](dotnet/install-scripts#593) from the install scripts - but your usage is really just a 'stable public release' usage anyway, which is the default. Signed-off-by: Chet Husk <[email protected]>
baronfel
added a commit
to baronfel/AssemblyLoader
that referenced
this pull request
Apr 17, 2025
The 'signed' quality is [being removed](dotnet/install-scripts#593) from the install scripts - but your usage is really just a 'stable public release' usage anyway, which is the default. Signed-off-by: Chet Husk <[email protected]>
baronfel
added a commit
to baronfel/Ranges
that referenced
this pull request
Apr 17, 2025
The 'signed' quality is [being removed](dotnet/install-scripts#593) from the install scripts - but your usage is really just a 'stable public release' usage anyway, which is the default. Signed-off-by: Chet Husk <[email protected]>
baronfel
added a commit
to baronfel/Sucrose.Avro.CodeGen
that referenced
this pull request
Apr 17, 2025
The 'signed' quality is [being removed](dotnet/install-scripts#593) from the install scripts - but your usage is really just a 'stable public release' usage anyway, which is the default.
baronfel
added a commit
to baronfel/BitField.Extensions
that referenced
this pull request
Apr 17, 2025
The 'signed' quality is [being removed](dotnet/install-scripts#593) from the install scripts - but your usage is really just a 'stable public release' usage anyway, which is the default.
baronfel
added a commit
to baronfel/AsyncTask
that referenced
this pull request
Apr 17, 2025
The 'signed' quality is [being removed](dotnet/install-scripts#593) from the install scripts - but your usage is really just a 'stable public release' usage anyway, which is the default.
This was referenced Apr 17, 2025
|
Merge as you will, then! |
Latency
approved these changes
Apr 18, 2025
Latency
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at usage data for the aka.ms links that back these qualities, it's clear that the only usage is from the tests in the install scripts repo itself. Removing these links has significant benefit to the overall time it takes to run our staging pipelines, as well as overall maintainability.