migrate frontend to chartjs 4 #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bruno-garcia could you may have a look? |
bruno-garcia
approved these changes
Feb 2, 2025
|
Also, CI fails because it requires a secret, that's not available on forks. I'll just merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve issue #274, I had to migrate the project to Chart.js version 3+ to address the reported problem. Given the presence of several breaking changes in version 3, I opted to update to the latest available version and adjust the codebase accordingly. The migration involved some refactoring of the Chart.js integration, including registering components explicitly, modifying tooltip callbacks, and updating configuration options to align with the new API.
As a result of the update, the animation bug was successfully resolved, and the chart now functions as expected.
Please refer to the attached GIF for a demonstration of the updated chart behavior.