Allow cohosting to make changes to source generated documents #77331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
| @@ -81,6 +81,11 @@ private static CompletionListCache GetCache() | |||
| return InlineCompletionsHandler.GetInlineCompletionItemsAsync(logger, document, position, options, xmlSnippetParser, cancellationToken); | |||
| } | |||
|
|
|||
| public static Document ApplyProvisionalEdit(SourceGeneratedDocument generatedDocument, SourceText updatedDocumentText) | |||
| { | |||
| return generatedDocument.Project.Solution.WithFrozenSourceGeneratedDocument(generatedDocument.Identity, DateTime.Now, updatedDocumentText); | |||
There was a problem hiding this comment.
@CyrusNajmabadi Did we use UtcNow for these, generally?
There was a problem hiding this comment.
Happy to update this, but just a note that the resulting document and the solution that contains it are thrown away immediately after asking for completion items from it
There was a problem hiding this comment.
Looks like DateTime.Now?
https://github.com/dotnet/roslyn/blob/main/src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompilationState.RegularCompilationTracker_Generators.cs#L294
I might have missed a spot though, was hard enough tracking down that one :)
3 tasks
ryzngard
approved these changes
Feb 25, 2025
|
Superseded by #77587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to enable Razor completion to work with the source generator.
Part of dotnet/razor#10693