JIT: Update gtHasLocalsWithAddrOp to use GenTreeVisitor #75672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change it to check for any local, not just GT_LCL_VAR.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsAlso change it to check for any local, not just GT_LCL_VAR.
|
|
cc @dotnet/jit-contrib, simple change with no diffs and some small TP improvements. |
AndyAyersMS
reviewed
Sep 16, 2022
Co-authored-by: Andy Ayers <[email protected]>
|
@AndyAyersMS Can you take another look? |
|
Diffs look spurious (#53773). I think the #53773 problem is more pronounced now that we have frozen objects too, we probably need a few JIT-EE interface changes to make sure that we can use the captured field addresses/object addresses during SPMI (JIT probably needs to ask the EE about values instead of dereferencing them directly, should probably help R2R/NAOT too). cc @EgorBo |
|
Ping @AndyAyersMS |
AndyAyersMS
approved these changes
Sep 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change it to check for any local, not just GT_LCL_VAR.