Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The loc build changes didn't flow to main so going directly. #28552

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

marcpopMSFT
Copy link
Member

No description provided.

Copy link
Member

@nagilson nagilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marc, may you please confirm the target branch for this is supposed to be main and not 7.0.2? I assume you are trying to get localization changes from internal 7.0.2 to go into main but wanted to be sure this wasn't meant to trigger for 7.0.2xx.

@marcpopMSFT marcpopMSFT merged commit 1924edc into main Oct 14, 2022
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-locbranch branch October 14, 2022 17:06
@marcpopMSFT
Copy link
Member Author

Marc, may you please confirm the target branch for this is supposed to be main and not 7.0.2? I assume you are trying to get localization changes from internal 7.0.2 to go into main but wanted to be sure this wasn't meant to trigger for 7.0.2xx.

Yes, I already made this change in 7.0.1xx which flowed to 7.0.2xx and then in the merge to main it got lost. Basically, right now we have both main and 7.0.2xx running loc builds and we only want 7.0.2xx. This disables it in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants