Suppress vstest terminal logger via environment variable #38286
Merged
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-dotnet test
untriaged
|
This works together with microsoft/vstest#4853 that ensures that specifying -p:VSTestUseMSBuildOutput=true won't put this in partially enabled state. But even before the other half is merged, this is okay to merge as well. |
cvpoienaru
approved these changes
Jan 26, 2024
Evangelink
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users, such as source-build are wrapping
dotnet testinto msbuild exec, and don't pass all the properties to it. Reuse the existing env variable to disable the new logger so it is easy to use in CI builds.