Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows build instruction #1588

Closed
wants to merge 0 commits into from
Closed

Update Windows build instruction #1588

wants to merge 0 commits into from

Conversation

martincostello
Copy link
Member

The Windows instruction says to run build.ps1, but there's no such file.

@dagood
Copy link
Member

dagood commented May 20, 2020

Hi @martincostello, Windows isn't currently supported in this repo: #1190. You'll see that even build.cmd turns around and tries to call the non-existent powershell script:

powershell -NoProfile -NoLogo -Command "& \"%~dp0build.ps1\" %*; exit $LastExitCode;"

Also, our main branch is release/3.1, if you'd like to help us update the readme there.

@martincostello martincostello changed the base branch from master to release/3.1 May 20, 2020 14:49
@martincostello martincostello deleted the patch-1 branch May 20, 2020 14:54
@martincostello
Copy link
Member Author

Fair enough - I only did a cursory read of the repo after seeing it in the 5.0 preview 4 release blog post. If it doesn't work at all for Windows, I'll just leave it.

@dagood
Copy link
Member

dagood commented May 20, 2020

Yeah, wish we had some time to set aside to make sure our docs and contrib guidance was clear before that link. This repo is quite unusual compared to the ones that make up the main components. Sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants