Don't convert CMake environment variables when using -x_noenv option
#11287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When having environment CMake variables in the form of `${....}` and using `doxygen -x_noenv` we still can get warnings like:
```
warning: argument '${EIGEN_DOXY_INTERNAL}' for option INTERNAL_DOCS is not a valid boolean value
Using the default: NO!
```
whilst in this case these environment variables should not give a warning and remain in the resulting Doxyfile. These variables are normally resolved by CMake, but when creating one's own Doxyfile based on a CMake Doxyfile.in without running CMake they should not be touched and not be converted to the default value.
(Found when doing some tests with the Eigen package).
albert-github
added
the
fixed but not released
doxygen
removed
the
fixed but not released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having environment CMake variables in the form of
${....}and usingdoxygen -x_noenvwe still can get warnings like:whilst in this case these environment variables should not give a warning and remain in the resulting Doxyfile. These variables are normally resolved by CMake, but when creating one's own Doxyfile based on a CMake Doxyfile.in without running CMake they should not be touched and not be converted to the default value.
(Found when doing some tests with the Eigen package).