Skip to content

Improve the MakeRuleCommand #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 31, 2025
Merged

Improve the MakeRuleCommand #323

merged 6 commits into from
Mar 31, 2025

Conversation

GeniJaho
Copy link
Collaborator

@GeniJaho GeniJaho commented Mar 27, 2025 •
edited
Loading

Improves the MakeRuleCommand since it's almost unusable at the moment.

  • Removes dependecy on symfony/finder
  • Adds a configurable option
  • Adds the ability to nest the rule in the correct directories, like If_/TestRector
  • Adds a simple test for the command
  • Updates Readme

Open to suggestions for further improvements.

@GeniJaho GeniJaho marked this pull request as ready for review March 27, 2025 20:29
@GeniJaho GeniJaho merged commit 8c25212 into main Mar 31, 2025
5 checks passed
@GeniJaho GeniJaho deleted the make-rule-command-fixes branch March 31, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GeniJaho